Welcome Guest   ·   Login   ·   Register   ·   Member List
Solspace.com  >  Forum Home  >  Solspace Modules  >  Tag  >  Thread
Search  
  
  Advanced Search
   
 
Bug Report for Tag 2.5 in the _db_charset_switch function
 
Sandwich
Posted: 28 October 2008 01:12 PM   [ Ignore ]
Newbie
Rank
Total Posts:  23
Joined  2007-12-12

I had posted a support thread over at the EE forums, and they finally tracked the problem down to the Tag module, and suggested that I file a bug report. Since the final conclusion they arrived at was over my head, I’m just going to link to the relevant thread:

Profile
 
 
Kelsey Martens
Posted: 29 October 2008 07:22 AM   [ Ignore ]   [ # 1 ]
Administrator
Avatar
RankRankRankRankRank
Total Posts:  10254
Joined  2006-10-18

Thanks Sandwich,

I’ll have a developer look into this one smile

 Signature 
Profile
 
 
Oxygen Smith
Posted: 31 October 2008 06:32 PM   [ Ignore ]   [ # 2 ]
Member
Avatar
RankRankRank
Total Posts:  167
Joined  2006-07-16

Pie man:

I’m getting the same error with Tag 2.5. The extension apparently interferes with related entries in some way, and thus the Playa extension I also need to use… I narrowed down the conflict to the Tag Submit extension by careful disabling/re-enabling of extensions.

The remedy was found at the same thread on the EE forums that Sandwich has linked up there: http://expressionengine.com/forums/viewthread/94644/—also linking there because it’s over my head too.

The thread talks about commenting out calls to _db_charset_switch in system/modules/tag/mod.tag.php as a short term fix, but I think I’d want to know exactly where to do that before I go mucking about in the Tag Submit extension.

R o B

 Signature 

Presently using this EE version for projects: EE 1.6.9, build 20100430

Profile
 
 
Kelsey Martens
Posted: 04 November 2008 08:35 AM   [ Ignore ]   [ # 3 ]
Administrator
Avatar
RankRankRankRankRank
Total Posts:  10254
Joined  2006-10-18

Oxygen,

Send me an email: kelsey AT solspace.com… I’ll get you a fixed copy smile

 Signature 
Profile
 
 
Wonder Monkey
Posted: 06 November 2008 06:29 PM   [ Ignore ]   [ # 4 ]
Member
Avatar
RankRankRank
Total Posts:  122
Joined  2005-09-13

Is this fixed in the 2.5.0 version now out? I’m running into the same problem.

Tak

Profile
 
 
Kelsey Martens
Posted: 06 November 2008 09:09 PM   [ Ignore ]   [ # 5 ]
Administrator
Avatar
RankRankRankRankRank
Total Posts:  10254
Joined  2006-10-18

This has been fixed officially in Tag 2.5.1 smile

http://www.solspace.com/forums/viewthread/661/

 Signature 
Profile
 
 
Oxygen Smith
Posted: 11 November 2008 12:47 PM   [ Ignore ]   [ # 6 ]
Member
Avatar
RankRankRank
Total Posts:  167
Joined  2006-07-16

I got a chance to install 2.5.1. today and upgrade to EE 1.6.5… I’m getting the same results as before :(

This is in conjunction with the Playa extension, however. I’ll have to test to see if it creates the same problems with regular related entries and reverse_related_entries.

 Signature 

Presently using this EE version for projects: EE 1.6.9, build 20100430

Profile
 
 
Sandwich
Posted: 12 November 2008 08:56 AM   [ Ignore ]   [ # 7 ]
Newbie
Rank
Total Posts:  23
Joined  2007-12-12

I’ve upgraded to Tag 2.5.1 today and am getting this problem again as well. I say “again” because Robin Sowell had gone through the mod.tag.php file on my server and commented out the calls to the problematic _db_charset_switch function. Unfortunately, I upgraded to Tag 2.5.1 assuming that the problem would remain gone, and didn’t make a backup of the modified files…

Profile
 
 
Kelsey Martens
Posted: 12 November 2008 09:11 AM   [ Ignore ]   [ # 8 ]
Administrator
Avatar
RankRankRankRankRank
Total Posts:  10254
Joined  2006-10-18

Sorry guys…

I’ll have a developer take a look at this right away smile

 Signature 
Profile
 
 
Kelsey Martens
Posted: 13 November 2008 01:37 PM   [ Ignore ]   [ # 9 ]
Administrator
Avatar
RankRankRankRankRank
Total Posts:  10254
Joined  2006-10-18

Sandwich / Oxygen,

Could you guys both provide CP and FTP access? I’ll also need revelant pages and templates to test and look into in case you’re running embeds, etc smile

Thanks

 Signature 
Profile
 
 
Kelsey Martens
Posted: 14 November 2008 02:49 PM   [ Ignore ]   [ # 10 ]
Administrator
Avatar
RankRankRankRankRank
Total Posts:  10254
Joined  2006-10-18

Sandwich,

Your site should be fixed now… have a look smile

Oxygen,

In mod.tag.php around line 800 or so,

Change this:

$cond['tagged'] = ( $saved )   ? TRUE: FALSE;
   $cond['not_tagged']  = ( ! $saved ) ? TRUE: FALSE;

   return $this->return_data = $FNS->prep_conditionals($tagdata, $cond);
} 

to this:

$cond['tagged'] = ( $saved )   ? TRUE: FALSE;
   $cond['not_tagged']  = ( ! $saved ) ? TRUE: FALSE;

   $this->_db_charset_switch('default');

   return $this->return_data = $FNS->prep_conditionals($tagdata, $cond);
} 
 Signature 
Profile
 
 
Sandwich
Posted: 17 November 2008 07:18 AM   [ Ignore ]   [ # 11 ]
Newbie
Rank
Total Posts:  23
Joined  2007-12-12

Yup, that seems to have done it. smile Will that change will be integrated into Tag from now on? I shouldn’t have to worry about upgrading to future versions, right?

Profile
 
 
Kelsey Martens
Posted: 17 November 2008 09:07 AM   [ Ignore ]   [ # 12 ]
Administrator
Avatar
RankRankRankRankRank
Total Posts:  10254
Joined  2006-10-18

Yes, the next version of Tag will include this smile

 Signature 
Profile
 
 
Oxygen Smith
Posted: 23 November 2008 04:38 PM   [ Ignore ]   [ # 13 ]
Member
Avatar
RankRankRank
Total Posts:  167
Joined  2006-07-16

Sorry Pie Man, I missed the earlier forum notification for some reason. I just upgraded the site to Tag 2.6 though, and have the same problem—I turn Tag 2.6 off, and all is well with the multi-relationships that Playa sets up. It’s as if there’s some clearing of the relationship cache that happens automatically when you alter a relationship in any entry that doesn’t happen when Tag is present. Playa seems to rely on this cache being cleared. Or so I think.

When I get back to my sites in a few days, I’ll try to see what’s going on in the module code, and I’ll give you a PM with CP access with instructions on how to reproduce the error. Thanks again smile

 Signature 

Presently using this EE version for projects: EE 1.6.9, build 20100430

Profile
 
 
Oxygen Smith
Posted: 09 December 2008 03:32 PM   [ Ignore ]   [ # 14 ]
Member
Avatar
RankRankRank
Total Posts:  167
Joined  2006-07-16

OK, I updated to Tag 2.6 and it didn’t help. However, it looks like Brandon Kelly made the “relationship cache” flush itself properly when you add or alter a relationship, in the new update to Playa, the multi-relationships extension I’ve been using. For some reason, the cache would flush itself normally, but when Tag was enabled, it wouldn’t, and the related entry wouldn’t display properly.

But that’s not the case now — so my problem’s solved. (BTW, I would’ve loved to solve the problem with Related Entries, but it wasn’t quite right for the workflow we required). Thanks guys!

 Signature 

Presently using this EE version for projects: EE 1.6.9, build 20100430

Profile
 
 
   
 
 
‹‹ Does EE v. 1.5 with the default jQuery extention...      Tag Module Install Error ››