[Freeform] Problems with Status
Posted: 26 June 2007 04:41 AM   [ Ignore ]
Newbie
Rank
Total Posts:  4
Joined  2005-10-14

First of all apologies to Mitchell. I only just found these Forums, so ignore my emails to you ...

I have 2 problems with status as a parameter in the Freefom tag.
First, in 2.5.2 this doesn’t change the default status of the entry. It always comes out as ‘Open’.
I can resolve this by going back to version 2.4.4

The other problem is that when I display the entries in the Freefom entries tag like this:

status="open|closed"

the I get a mysql error.
I have discovered where I think the error is:
In line 1453 of the mod.freeform.php file it should say:

$sql    .= "status = '".$stat."' OR ";

Notice the space before and after the ‘OR’. - This certainly fixes it!

Any ideas on the this (have I got this right) and the first error above?

Chris J

Profile
 
 
Posted: 26 June 2007 08:17 AM   [ Ignore ]   [ # 1 ]
Sr. Member
Avatar
RankRankRankRank
Total Posts:  336
Joined  2005-07-09

cj, thanks for bringing this to our attention. I have moved this to bug reports, and the appropriate programmers have been notified.

 Signature 

Ingmar Greil

Profile
 
 
Posted: 26 June 2007 08:21 AM   [ Ignore ]   [ # 2 ]
Sr. Member
Avatar
RankRankRankRank
Total Posts:  336
Joined  2005-07-09

First of all apologies to Mitchell. I only just found these Forums, so ignore my emails to you ...

By the way, he has not been ignoring you, but Mitchell’s been away on his honeymoon until yesterday, and probably has not caught up with the deluge of mail undoubtedly waiting for him…

 Signature 

Ingmar Greil

Profile
 
 
Posted: 09 August 2007 01:43 PM   [ Ignore ]   [ # 3 ]
Newbie
Rank
Total Posts:  3
Joined  2007-07-26
cj - 26 June 2007 04:41 AM

First of all apologies to Mitchell. I only just found these Forums, so ignore my emails to you ...

I have 2 problems with status as a parameter in the Freefom tag.
First, in 2.5.2 this doesn’t change the default status of the entry. It always comes out as ‘Open’.
I can resolve this by going back to version 2.4.4

Chris J

I am also experiencing this error.  As a work around I changed the MySQL default value for status from open to closed, this is not ideal, but it might work for you.

I emailed Mitchell about this and he said it will be fixed in the next release.

Profile
 
 
Posted: 27 August 2007 05:40 AM   [ Ignore ]   [ # 4 ]
Sr. Member
Avatar
RankRankRankRank
Total Posts:  336
Joined  2005-07-09

Peter, can you confirm it’s been fixed in the 2.5.4 release? Is that working for you now?

 Signature 

Ingmar Greil

Profile
 
 
Posted: 05 September 2007 10:25 AM   [ Ignore ]   [ # 5 ]
Newbie
Rank
Total Posts:  3
Joined  2007-07-26
Ingmar - 27 August 2007 05:40 AM

Peter, can you confirm it’s been fixed in the 2.5.4 release? Is that working for you now?

Sorry I guess I missed the 2.5.4 release party.  I have installed and tested 2.5.6.

I find that it is still ignoring the status=’’ parameter.

Looking at the code of the module it appears that the status parameter is not captured in the section of the code marked “Grab our tag data”, where I might otherwise expect to see it.

In short 2.5.6 still has the problem reported in 2.5.3

Profile
 
 
Posted: 05 September 2007 10:39 AM   [ Ignore ]   [ # 6 ]
Administrator
Avatar
RankRankRankRank
Total Posts:  702
Joined  2004-03-30

Sorry for the inconvenience on this. I’ll have this knocked out shortly.

mk

 Signature 

Mitchell Kimbrough

Profile
 
 
Posted: 05 September 2007 11:50 AM   [ Ignore ]   [ # 7 ]
Administrator
Avatar
RankRankRankRank
Total Posts:  702
Joined  2004-03-30

2.5.7 is ready and fixes the status bugs.

 Signature 

Mitchell Kimbrough

Profile
 
 
Posted: 05 September 2007 12:28 PM   [ Ignore ]   [ # 8 ]
Newbie
Rank
Total Posts:  3
Joined  2007-07-26
Mitchell Kimbrough - 05 September 2007 11:50 AM

2.5.7 is ready and fixes the status bugs.

It sure does.

Thanks Mitchell!!!

Profile